8000 Release v2.3.1 by lan496 · Pull Request #428 · spglib/spglib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release v2.3.1 #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2024
Merged

Release v2.3.1 #428

merged 1 commit into from
Feb 11, 2024

Conversation

lan496
Copy link
Member
@lan496 lan496 commented Feb 9, 2024

Closes #424

After this PR is merged, I'll put v2.3.1-rc1 tag to the commit first. Then v2.3.1 tag.

@codecov Codecov
Copy link
codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b18822) 83.71% compared to head (4949c99) 83.71%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #428   +/-   ##
========================================
  Coverage    83.71%   83.71%           
========================================
  Files           24       24           
  Lines         8205     8205           
========================================
  Hits          6869     6869           
  Misses        1336     1336
Flag Coverage Δ
c_api 77.50% <ø> (ø)
fortran_api 56.33% <ø> (ø)
python_api 79.94% <ø> (ø)
unit_tests 1.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 requested review from LecrisUT and atztogo February 9, 2024 23:54
atztogo
atztogo approved these changes Feb 10, 2024
View reviewed changes
Copy link
Collaborator
@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lan496!

LecrisUT
LecrisUT approved these changes Feb 10, 2024
View reviewed changes
Copy link
Collaborator
@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put multiple tags on the same commit, or at least delete the old tag and wait a while before tagging a new one.

There was an issue where the git archive sha changed and my suspicion is that that's what caused it. (The .git_archival.txt file changes on every commit and tag)

@lan496 lan496 merged commit a6d3d3f into spglib:develop Feb 11, 2024
@lan496
Copy link
Member Author
lan496 commented Feb 11, 2024

I see. Then, I just put v2.3.1 tag

@lan496
Copy link
Member Author
lan496 commented Feb 11, 2024 
gco -
git pull upstream develop
git tag v2.3.1
git push upstream v2.3.1

@lan496
Copy link
Member Author
lan496 commented Feb 11, 2024

Uploaded to PyPI
https://pypi.org/project/spglib/2.3.1/

@lan496
Copy link
Member Author
lan496 commented Feb 11, 2024

GitHub release note https://github.com/spglib/spglib/releases/tag/v2.3.1

@Porkepix Porkepix mentioned this pull request Feb 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atztogo atztogo atztogo approved these changes

@LecrisUT LecrisUT LecrisUT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release v2.3.1
3 participants
@lan496 @atztogo @LecrisUT
0