8000 chore: Make measure_rigid_rotation static by atztogo · Pull Request #453 · spglib/spglib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Make measure_rigid_rotation static #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

chore: Make measure_rigid_rotation static #453

merged 1 commit into from
Feb 28, 2024

Conversation

atztogo
Copy link
Collaborator
@atztogo atztogo commented Feb 28, 2024

close #451.

@atztogo atztogo requested a review from lan496 February 28, 2024 04:12
@codecov Codecov
Copy link
codecov bot commented Feb 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.59%. Comparing base (7945756) to head (89a1a8b).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #453   +/-   ##
========================================
  Coverage    83.59%   83.59%           
========================================
  Files           24       24           
  Lines         8118     8118           
  Branches      1693     1688    -5     
========================================
  Hits          6786     6786           
  Misses        1332     1332
Flag Coverage Δ
c_api 74.43% <100.00%> (ø)
fortran_api 56.16% <100.00%> (ø)
python_api 79.70% <100.00%> (ø)
unit_tests 13.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT changed the title Made measure_rigid_rotation private chore: Make measure_rigid_rotation static Feb 28, 2024
@lan496 lan496 merged commit 7e7fe81 into spglib:develop Feb 28, 2024
@atztogo atztogo deleted the measure_rigid_rotation branch February 28, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lan496 lan496 lan496 approved these changes

@LecrisUT LecrisUT LecrisUT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ref_measure_rigid_rotation can be a private function
3 participants
@atztogo @lan496 @LecrisUT
0