8000 Release v2.4.0 by lan496 · Pull Request #467 · spglib/spglib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release v2.4.0 #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2024
Merged

Release v2.4.0 #467

merged 1 commit into from
Apr 11, 2024

Conversation

lan496
Copy link
Member
@lan496 lan496 commented Apr 11, 2024

Closes #434

After this PR is merged, I'll put v2.4.0 tag to the commit.

@lan496 lan496 requested review from LecrisUT and atztogo April 11, 2024 10:56
@codecov Codecov
Copy link
codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.80%. Comparing base (3785a2d) to head (ff1ea66).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #467   +/-   ##
========================================
  Coverage    83.80%   83.80%           
========================================
  Files           25       25           
  Lines         8164     8164           
  Branches      1697     1705    +8     
========================================
  Hits          6842     6842           
  Misses        1322     1322
Flag Coverage Δ
c_api 74.71% <ø> (ø)
fortran_api 56.20% <ø> (ø)
python_api 80.04% <ø> (ø)
unit_tests 13.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LecrisUT
LecrisUT approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator
@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

One thing we might need to consider is the usage of PR links, it is a bit inconsistent right now. For the file, git blame can be used to find when an entry was added, but adding the links might be useful for the user to navigate those changes as well. On the other hand is the user using ChangeLog.md or the release pages?

I have found a neat GH action (c 8000 hangesets/action) that mystmd is using which generates the Release PR after each commit. That would help keep things more consistent.

@lan496 lan496 merged commit e6bdd0b into spglib:develop Apr 11, 2024
@lan496
Copy link
Member Author
lan496 commented Apr 11, 2024 
gco -
git pull upstream develop
git tag v2.4.0
git push upstream v2.4.0

@LecrisUT
Copy link
Collaborator

BTW, we need to fix this issue before the next release. I have made a bit of noise on Fedora and upstream setuptools-scm to get some ideas on how to handle this. Nothing we can do right now until we find a compatible solution

@lan496
Copy link
Member Author
lan496 commented Apr 11, 2024

One thing we might need to consider is the usage of PR links, it is a bit inconsistent right now.

I'm not sure what is inconsistent. Does it mean that the PR link itself does not indicate the commit where the change was included?

On the other hand is the user using ChangeLog.md or the release pages?

I have no idea...

@LecrisUT
Copy link
Collaborator

I'm not sure what is inconsistent. Does it mean that the PR link itself does not indicate the commit where the change was included?

Some entries have the PR link at the beginning of the entry, some do not. In the Main Changes section I do not believe it would be good to have, but for the other sections, it can go either way. For most cases I don't add them because there can be multiple changes that are documented in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atztogo atztogo atztogo approved these changes

@LecrisUT LecrisUT LecrisUT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release v2.4.0
3 participants
@lan496 @LecrisUT @atztogo
0