8000 Release v2.1.0 by lan496 · Pull Request #324 · spglib/spglib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release v2.1.0 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2023
Merged

Release v2.1.0 #324

merged 1 commit into from
Sep 10, 2023

Conversation

lan496
Copy link
Member
@lan496 lan496 commented Sep 10, 2023

Close: #239

After this PR is merged, I'll put v2.1.0 tag to the commit.

@lan496 lan496 requested review from LecrisUT and atztogo September 10, 2023 02:33
@lan496 lan496 self-assigned this Sep 10, 2023
@lan496
Copy link
Member Author
lan496 commented Sep 10, 2023

Note: I generated the list of PRs by gh command though this task will be automated in future.

gh pr list --state merged --limit 99 --json url,title,number | jq -r '.[] | "[[#\(.number)]](\(.url)) - \(.title)"'

@lan496
Copy link
Member Author
lan496 commented Sep 10, 2023

What happened on rpm-build CIs?

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (e0e5c54) 83.60% compared to head (6f4dbfb) 83.60%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #324   +/-   ##
========================================
  Coverage    83.60%   83.60%           
========================================
  Files           23       23           
  Lines         7942     7942           
========================================
  Hits          6640     6640           
  Misses        1302     1302
Flag Coverage Δ
c_api 76.10% <ø> (ø)
fortran_api 36.82% <ø> (ø)
python_api 80.42% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
8000

atztogo
atztogo approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator
@atztogo atztogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lan496, thanks for your work. Probably categorising commits requires some effort.

@LecrisUT
Copy link
Collaborator
LecrisUT commented Sep 10, 2023 •
edited
Loading

That is weird, aarch64 are failing due to the build system infrastructure, I'll ask around what is going on.

Last build was successful so you can go ahed with this one. (On the fedora downstream side, there is a different infrastructure)

@lan496 lan496 merged commit 59bea8a into spglib:develop Sep 10, 2023
@lan496
Copy link
Member Author
lan496 commented Sep 10, 2023

I've pushed v2.1.0 tag to upstream.

git checkout develop
git pull upstream develop
git tag v2.1.0
git push upstream v2.1.0

@lan496
Copy link
Member Author
lan496 commented Sep 10, 2023

https://github.com/spglib/spglib/actions/runs/6135805202/job/16650183543
Configuration for Trusted Publisher seems to be incorrect.

@lan496
Copy link
Member Author
lan496 commented Sep 10, 2023

Rerun the failed pypi publish after fixing Trusted Publisher Management in PyPI and TestPyPI (fix to rename release.yml to release.yaml).

@lan496
Copy link
Member Author
lan496 commented Sep 10, 2023

spglib v2.1.0 is published in PyPI 🎉
https://pypi.org/project/spglib/

@lan496
Copy link
Member Author
lan496 commented Sep 10, 2023

GitHub's release is nicely generated: https://github.com/spglib/spglib/releases/tag/untagged-6db672e52eb611e6598b

@LecrisUT
Copy link
Collaborator

@lan496 please convert draft releases to proper releases after you reviewed it

@lan496
Copy link
Member Author
lan496 commented Sep 10, 2023

@LecrisUT Thanks. I've converted. I didn't know that a draft is not seen by the public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atztogo atztogo atztogo approved these changes

@LecrisUT LecrisUT LecrisUT approved these changes

Assignees

@lan496 lan496

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 2.1
4 participants
@lan496 @codecov-commenter @LecrisUT @atztogo
0