fix: Python installation when running outside skbuild #335
Conversation
69f5f3a to
9eecab4
Compare
|
I do not fully understand the context, but do we need address sanitizer for the Python interface? |
|
The core issue is not with the python interface having the address sanitizer, but that the C library tests do not cover all cases. That's why the main thing to do is #303 so we can move the main tests to ctest and not have the pytests run with sanitizers (at least not always) |
6e1d018 to
a44dc32
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #335 +/- ##
========================================
Coverage 83.59% 83.59%
========================================
Files 24 24
Lines 8119 8119
Branches 1694 1687 -7
========================================
Hits 6787 6787
Misses 1332 1332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cba6edc to
cab6084
Compare
|
@LecrisUT Please assign me when ready for review. |
|
Let me review this PR next. |
- Added potentially missing _version.py file Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
| - name: Install dependencies | ||
| run: | | ||
| python3 -m pip install pip-tools | ||
| pip-compile --extra=test --strip-extras pyproject.toml ${{ matrix.pre && '--pre' }} |
There was a problem hiding this comment.
Why does this PR generate requirements.txt here? To lock package versions?
There was a problem hiding this comment.
pip does not have a mode to install only dependencies, and that is the closest approach I've found to do that. What I wanted to be covered there is the case where the Spglib is built without scikit-build-core being involved. Weird though that it didn't error out in the previous iterations where I didn't include configure_file(_version.py.in spglib/_version.py)
There was a problem hiding this comment.
Although I feel tricky, it makes sense. Thanks!
There was a problem hiding this comment.
I fully agree. Eventually I hope the skbuild-cli will be implemented, at which point we wouldn't need to care about such difference.
Closes: #330 #344 #429
Depends on: #397