8000 Use downstream tmt tests by LecrisUT · Pull Request #356 · spglib/spglib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use downstream tmt tests #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2024
Merged

Use downstream tmt tests #356

merged 1 commit into from
Jan 20, 2024

Conversation

LecrisUT
Copy link
Collaborator
@LecrisUT LecrisUT commented Nov 9, 2023 •
edited
Loading

Using downstream tests so that we don't need to maintain them as much

@LecrisUT LecrisUT mentioned this pull request Nov 13, 2023
Closed
@LecrisUT LecrisUT force-pushed the fedora/downstream-tmt branch from 6880b5d to 03756e1 Compare November 14, 2023 09:57
@LecrisUT
Copy link
Collaborator Author

This one needs some upstream fixes to fix passing environment variables and files

@lan496 lan496 marked this pull request as draft January 7, 2024 04:50
@LecrisUT LecrisUT force-pushed the fedora/downstream-tmt branch from 03756e1 to 77c0091 Compare January 18, 2024 10:47
@LecrisUT LecrisUT marked this pull request as ready for review January 18, 2024 10:49
@LecrisUT LecrisUT mentioned this pull request Jan 18, 2024
Merged
@codecov-commenter
Copy link
codecov-commenter commented Jan 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ce87bc) 83.86% compared to head (14866da) 83.86%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #356   +/-   ##
========================================
  Coverage    83.86%   83.86%           
========================================
  Files           24       24           
  Lines         8180     8180           
========================================
  Hits          6860     6860           
  Misses        1320     1320
Flag Coverage Δ
c_api 77.59% <ø> (ø)
fortran_api 56.15% <ø> (ø)
python_api 80.38% <ø> (ø)
unit_tests 1.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT force-pushed the fedora/downstream-tmt branch from 77c0091 to 1803f03 Compare January 18, 2024 13:32
@LecrisUT
Copy link
Collaborator Author
LecrisUT commented Jan 18, 2024 •
edited
Loading

/packit test

@LecrisUT
Use downstream tmt tests
4d10b39 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT force-pushed the fedora/downstream-tmt branch 2 times, most recently from 14866da to 4d10b39 Compare January 19, 2024 17:49
@LecrisUT LecrisUT merged commit f855378 into spglib:develop Jan 20, 2024
@LecrisUT LecrisUT deleted the fedora/downstream-tmt branch January 20, 2024 00:16
@LecrisUT LecrisUT added this to the 2.3 milestone Jan 25, 2024
@chenrui333 chenrui333 mentioned this pull request Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lan496 lan496 lan496 approved these changes

Assignees

@lan496 lan496

Labels
None yet
Projects
Spglib developers' kanban
Status: ✅ Done
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@LecrisUT @codecov-commenter @lan496
0