8000 fix: windows-ci by LecrisUT · Pull Request #358 · spglib/spglib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: windows-ci #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix: windows-ci #358

merged 2 commits into from
Nov 14, 2023

Conversation

LecrisUT
Copy link
Collaborator
@LecrisUT LecrisUT commented Nov 9, 2023

No description provided.

@LecrisUT LecrisUT self-assigned this Nov 9, 2023
@LecrisUT LecrisUT added the bug label Nov 9, 2023
@codecov-commenter
Copy link
codecov-commenter commented Nov 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a96d72a) 83.56% compared to head (53132bb) 83.68%.
Report is 22 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #358      +/-   ##
===========================================
+ Coverage    83.56%   83.68%   +0.12%     
===========================================
  Files           24       24              
  Lines         8157     8144      -13     
===========================================
- Hits          6816     6815       -1     
+ Misses        1341     1329      -12
Flag Coverage Δ
c_api 76.45% <100.00%> (+0.01%) ⬆️
fortran_api 56.29% <80.00%> (-0.02%) ⬇️
python_api 80.54% <80.00%> (+0.12%) ⬆️
unit_tests 1.24% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/arithmetic.c 100.00% <ø> (ø)
src/cell.c 74.56% <100.00%> (-0.27%) ⬇️
src/spglib.c 72.48% <100.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LecrisUT LecrisUT marked this pull request as ready for review November 13, 2023 12:50
@LecrisUT LecrisUT assigned lan496 and unassigned LecrisUT Nov 13, 2023
@LecrisUT
Copy link
Collaborator Author

@lan496 Can you mark CI/pass workflow job as a required CI. That way it is easier to filter out when the failing tests are due to experimental jobs, i.e. CI/pass is failed, only if the non-experimental jobs are failing.

Here's an example of where to find the settings:
Screenshot_20231113_135233
8000

@LecrisUT
[Temp] Use windows-2019 for GitHub Action
f4cec18 
The CIs are failing on the `windows-latest` due to the address-sanitizer. Maybe it requires additional static linkage flags. Needs to be investigated
@LecrisUT
Add latest macos and windows as experimental
53132bb
@LecrisUT LecrisUT mentioned this pull request Nov 13, 2023
Merged
@lan496
Copy link
Member
lan496 commented Nov 14, 2023

@LecrisUT Done.
image

@LecrisUT
Copy link
Collaborator Author

Great thank you. I will merge this one so we can unlock the other PRs

@LecrisUT LecrisUT merged commit 8fab0b0 into spglib:develop Nov 14, 2023
@Porkepix Porkepix mentioned this pull request Dec 8, 2023
Merged
@LecrisUT LecrisUT mentioned this pull request Jan 13, 2024
Merged
@LecrisUT LecrisUT deleted the fix/windows-ci branch January 25, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lan496 lan496

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LecrisUT @codecov-commenter @lan496
0