8000 add missing license identifiers by armintaenzertng · Pull Request #557 · spdx/tools-python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add missing license identifiers #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

armintaenzertng
Copy link
Collaborator

No description provided.

Copy link
Collaborator
@
8000
meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some misconfiguration..

@armintaenzertng armintaenzertng force-pushed the addMissingLicenseHeaders branch from f3efdcb to 6746243 Compare April 3, 2023 10:26
meretp
meretp previously approved these changes Apr 3, 2023
Copy link
Collaborator
@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One small remark from my side for the sake of consistency but nothing merge-blocking.

Comment on lines 1 to 3
# SPDX-FileCopyrightText: 2022 spdx contributors

# SPDX-License-Identifier: Apache-2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# SPDX-FileCopyrightText: 2022 spdx contributors
# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: 2022 spdx contributors
#
# SPDX-License-Identifier: Apache-2.0

I don't think that this is additional hastag is necessary but it would make these changes concsistent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, needs another approval ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does also apply to the other test files 😇

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and also to almost all other files, apparently^^
Have look again ;)

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng armintaenzertng force-pushed the addMissingLicenseHeaders branch from 11b71b4 to 9a71403 Compare April 3, 2023 10:48
Copy link
Collaborator
@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making this consistent! I didn't look at every single file but when I scrolled over it, it all looked good! 👍

@armintaenzertng armintaenzertng merged commit ac9e62f into spdx:main Apr 3, 2023
@armintaenzertng armintaenzertng deleted the addMissingLicenseHeaders branch April 3, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0