docs: add VMO cluster deployment DOC-1358 #46
+7,709
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c127eb5 to
d1ac9fe
Compare
docs: add creation of virtual machine docs: add test cases DOC-1358 docs: add readme DOC-1358
d1ac9fe to
4698a97
Compare
caroldelwing
approved these changes
Jan 16, 2025
addetz
commented
Jun 17, 2025
terraform/vmo-cluster/clusters.tf
Outdated
Comment on lines
30
to
33
| instance_type { | ||
| min_cpu = var.ctl-node-min-cpu | ||
| min_memory_mb = var.ctl-node-min-memory-mb | ||
| } |
There was a problem hiding this comment.
Suggest name variables using the same format. Something like maas-control-node-min-cpu and maas-control-node-min-memory-mb.
terraform/vmo-cluster/clusters.tf
Outdated
Comment on lines
44
to
47
| instance_type { | ||
| min_cpu = var.wrk-node-min-cpu | ||
| min_memory_mb = var.wrk-node-min-memory-mb | ||
| } |
There was a problem hiding this comment.
Same comment about the naming. maas-worker-node-min-cpu and maas-worker-node-min-memory-mb
terraform/vmo-cluster/data.tf
Outdated
| data "spectrocloud_cluster" "maas_vmo_cluster" { | ||
| count = var.deploy-maas-vm ? 1 : 0 | ||
| depends_on = [spectrocloud_cluster_maas.maas-cluster] | ||
| name = "vmo-cluster-maas" |
There was a problem hiding this comment.
This needs to use the var as well now that you have provided one.
terraform/vmo-cluster/inputs.tf
Outdated
Comment on lines
34
to
36
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Delete these empty lines?
terraform/vmo-cluster/inputs.tf
Outdated
|
|
||
| variable "cluster-profile-type" { | ||
| type = string | ||
| description = "The name of the PCG that will be used to deploy the cluster." |
There was a problem hiding this comment.
The description is copy-pasta.
terraform/vmo-cluster/tests/virtual-machines-replace-values.tftest.hcl
Outdated
Show resolved
Hide resolved
Comment on lines
67
to
71
| vm-storage-Gi = "50Gi" # Size of the disk (PVC) that your VM will have. | ||
| vm-cpu-cores = 2 # Number of CPU cores your VM will have. | ||
| vm-cpu-sockets = 1 # Number of physical CPU sockets the CPU cores should be spread over. | ||
| vm-cpu-threads = 2 # Number of CPU threads to use for the VM CPU | ||
| vm-memory-Gi = "4Gi" # Amount of RAM (memory) your VM will have |
There was a problem hiding this comment.
Should these be templated in the vmo-extras manifest?
| cluster_context = data.spectrocloud_cluster.maas_vmo_cluster[0].context | ||
|
|
||
| #run_on_launch = true | ||
| run_strategy = "Halted" |
There was a problem hiding this comment.
Does this still need to be Halted?
caroldelwing
requested changes
Jun 17, 2025
| guest = var.vm-memory-Gi | ||
| } | ||
|
|
||
| resources {} |
There was a problem hiding this comment.
is this empty block required?
terraform/vmo-cluster/tests/virtual-machine-missing-values.tftest.hcl
Outdated
Show resolved
Hide resolved
terraform/vmo-cluster/tests/virtual-machines-replace-values.tftest.hcl
Outdated
Show resolved
Hide resolved
terraform/vmo-cluster/tests/virtual-machines-replace-values.tftest.hcl
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR adds the VMO cluster deployment and VM creation example.
Review Changes
🎫 DOC-1358