8000 PSBT nostr, send invoice/tx description along with PSBT by accumulator · Pull Request #9793 · spesmilo/electrum · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PSBT nostr, send invoice/tx description along with PSBT #9793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

PSBT nostr, send invoice/tx description along with PSBT #9793

merged 2 commits into from
May 15, 2025
+133 −90

Conversation

accumulator
Copy link
Member

No description provided.

@accumulator accumulator mentioned this pull request May 6, 2025
Closed
@accumulator accumulator changed the title Psbt nostr send description PSBT nostr, send invoice/tx description along with PSBT May 9, 2025
@accumulator accumulator closed this May 9, 2025
@accumulator accumulator force-pushed the psbt_nostr_send_description branch from a8fec38 to 08d4c4d Compare May 9, 2025 09:37
@accumulator accumulator reopened this May 9, 2025
@accumulator accumulator mentioned this pull request May 9, 2025
Merged
@accumulator accumulator added this to the 4.6.0 milestone May 13, 2025
@ecdsa
Copy link
Member
ecdsa commented May 14, 2025

LGTM, but I have not tested it

@f321x
Copy link
Member
f321x commented May 14, 2025 •
edited
Loading

On qt it works fine for me, on QML there were some issues:

  1. When creating a request, the label is only encoded in the Request URI if also an amount is specified. If i only enter a label and no amount, the request will only contain the address, not the label or expiration date.

  2. When sending a psbt with label, it is correctly shown in the popup on receiver side, however in the following transaction it gets lost and is not shown.
    Screencast_20250514_102827.webm

  3. Moved to bug: qml: function called on wrong thread when saving psbt to wallet #9829

@accumulator accumulator force-pushed the psbt_nostr_send_description branch from 08d4c4d to ecce6f1 Compare May 14, 2025 08:57
@accumulator
Copy link
Member Author
accumulator commented May 14, 2025 •
edited
Loading

On qt it works fine for me, on QML there were some issues:

1. When creating a request, the label is only encoded in the Request URI if also an amount is specified. If i only enter a label and no amount, the request will only contain the address, not the label or expiration date.

2. When sending a psbt with label, it is correctly shown in the popup on receiver side, however in the following transaction it gets lost and is not shown.
   [Screencast_20250514_102827.webm](https://github.com/user-attachments/assets/c230cd08-de99-4874-9450-14fa4f417481)

3. When saving a received psbt to the wallet it (sometimes?) throws the following exception:

Thx for testing.
(1) is a pre-existing issue, if no amount is specified, it just shows the address and not a bip21 uri. As users might need just the address in certain cases (e.g. withdraw from exchange), I would propose to generate a bip21 when label or amount is set, and generate an address when label and amount are empty, regardless of expiration setting. I'll make a separate PR for this.

(2) indeed. I'll have a look

(3) I haven't seen this before, will have a look.

@accumulator
Copy link
Member Author

(2) is correctly handled in the followup PR #9800

@accumulator
qt: pass Invoice object to transaction dialog when appropriate.
6566f2f 
This is purely informational and optional, with the main immediate use to provide the
invoice description/message/label to the transaction dialog, so it can be stored
when saving the tx in history, or passed along with PSBTs sent to cosigners.

Before, the tx description was not saved in history when an invoice was not saved before
signing and saving the tx for sending later.
@accumulator
psbt_nostr: send label along with PSBT
a9213c4
@accumulator accumulator force-pushed the psbt_nostr_send_description branch from ecce6f1 to a9213c4 Compare May 14, 2025 10:50
@accumulator
Copy link
Member Author

(1) see #9824

@ecdsa
Copy link
Member
ecdsa commented May 15, 2025

I think (3) is a preexisting issue, not related to this PR. please fix it separately.

@ecdsa ecdsa merged commit 33ea89c into spesmilo:master May 15, 2025
14 checks passed
@f321x
Copy link
Member
f321x commented May 15, 2025

Moved (3) into a separate issue #9829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@accumulator @ecdsa @f321x
0