-
Notifications
You must be signed in to change notification settings - Fork 3.2k
PSBT nostr, send invoice/tx description along with PSBT #9793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSBT nostr, send invoice/tx description along with PSBT #9793
Conversation
a8fec38
to
08d4c4d
Compare
LGTM, but I have not tested it |
On qt it works fine for me, on QML there were some issues:
|
08d4c4d
to
ecce6f1
Compare
Thx for testing. (2) indeed. I'll have a look (3) I haven't seen this before, will have a look. |
(2) is correctly handled in the followup PR #9800 |
This is purely informational and optional, with the main immediate use to provide the invoice description/message/label to the transaction dialog, so it can be stored when saving the tx in history, or passed along with PSBTs sent to cosigners. Before, the tx description was not saved in history when an invoice was not saved before signing and saving the tx for sending later.
ecce6f1
to
a9213c4
Compare
(1) see #9824 |
I think (3) is a preexisting issue, not related to this PR. please fix it separately. |
Moved (3) into a separate issue #9829 |
No description provided.