Support converting string float numbers to integer types #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
ccoVeille
suggested changes
Jun 1, 2025
| @@ -400,7 +401,7 @@ func parseInt[T integer](s string) (T, error) { | |||
| } | |||
|
|
|||
| func parseUint[T unsigned](s string) (T, error) { | |||
| v, err := strconv.ParseUint(trimZeroDecimal(s), 0, 0) | |||
| v, err := strconv.ParseUint(trimDecimal(s), 0, 0) | |||
There was a problem hiding this comment.
I'm suspicious here
It works for the expected case. The one that caused to code this.
But what about the string "10...17" previously it was returning an error, now it will happily return 10
https://go.dev/play/p/bkiLc4jdBEH
vs
https://go.dev/play/p/VyqcbrcMEWk
The issue is worst if you consider:
- 10.foobar (invalid)
- 10.0i (a complex)
- 10.0E9 (unsupported syntax previously)
All of them are now returning 10
There was a problem hiding this comment.
Fair enough. Let me try to fix that.
cloudxxx8
added a commit
to cloudxxx8/device-rest-go
that referenced
this pull request
Jun 9, 2025
Fixed the unit tests to meet the change of spf13 v1.9 spf13/cast#261 Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
5 tasks
judehung
pushed a commit
to edgexfoundry/device-rest-go
that referenced
this pull request
Jun 9, 2025
Fixed the unit tests to meet the change of spf13 v1.9 spf13/cast#261 Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204
Fixes #189
Fixes #172
Fixes #210
Fixes #170