8000 Use HELIOS_CERT_PATH env var by davidxia · Pull Request #810 · spotify/helios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Use HELIOS_CERT_PATH env var #810

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Use HELIOS_CERT_PATH env var #810

merged 1 commit into from
Jan 11, 2016

Conversation

davidxia
Copy link
Contributor

No description provided.

@davidxia
Copy link
Contributor Author

@mattnworb

@davidxia
Copy link
Contributor Author

@codecov-io
Copy link

Current coverage is 44.97%

Merging #810 into master will increase coverage by +0.01% as of cb80a69

@@            master    #810   diff @@
======================================
  Files          261     261       
  Stmts        10926   10925     -1
  Branches      1521    1521       
  Methods          0       0       
======================================
  Hit           4913    4913       
  Partial        442     442       
+ Missed        5571    5570     -1

Review entire Coverage Diff as of cb80a69

Powered by Codecov. Updated on successful CI builds.

@mattnworb
Copy link
Member

d'oh. The code was shadowing clientCertificatePath but then assigning to this.clientCertificatePath but then passing clientCertificatePath to the HeliosClient ctor.

@mattnworb
Copy link
Member

👍

davidxia added a commit that referenced this pull request Jan 11, 2016
@davidxia davidxia merged commit 4c829bf into master Jan 11, 2016
@davidxia davidxia deleted the dxia/fix-cert-path branch January 11, 2016 21:14
vbhavsar pushed a commit that referenced this pull request Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0