Extended inherits/requires decorators support multiple parents #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ifiddes, thanks for your PR! By analyzing the annotation information on this pull request, we identified @drj42, @erikbern and @steenzout to be potential reviewers |
|
This seem like sensible addition. I rarely use these util functions. So if somebody cold review that would be sweet. But as you hinted in your comments, I think one might as well replace |
|
lgtm |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If closed, you may revisit when your time allows and reopen! Thank you for your contributions. |
Merged
|
Closing due to merge of #2475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
These decorators simplify creating more complicated dependency graphs where one task either depends on or inherits characteristics from more than one parent task.
Technically, you could replace
@requiresand@inheritsentirely with these versions, as they support singular input. If you want me to do that, I can change the PR.Have you tested this? If so, how?
I have not produced unit tests for this yet, but it works within my own code base. It is a fairly simple logical extension of the base versions of these decorators.