added a new event 'progress' #2498
Merged
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This event can be fired by the task itself while running. The purpose is for the task to report progress, metadata or any generic info so that event handler listening for this can keep track of the progress of running task.
|
LGTM |
dlstadther
approved these changes
Aug 22, 2018
|
One urging side thought - there is some existing code already, catering for similar communication:
I guess anyway the use of events would be preferable, could allow us to eventually replace the ad-hoc code? |
|
Are those for communication from worker to scheduler? If that is the case, it doesn't seem to fit very well to our use case. |
Tarrasch
reviewed
Aug 22, 2018
|
@Tarrasch 👍 for that, will fix. |
honnix
commented
Aug 23, 2018
| @@ -25,6 +25,10 @@ class Event(object): | |||
| DEPENDENCY_PRESENT = "event.core.dependency.present" | |||
| BROKEN_TASK = "event.core.task.broken" | |||
| START = "event.core.start" | |||
| #: This event can be fired by the task itself while running. The purpose is | |||
There was a problem hiding this comment.
Tried following existing inline doc. How does it look? @Tarrasch
|
I didn't mean to include communication with the scheduler in our solution. It was just an aside comment, that we'll now be "reporting progress" in 2 different ways, and that I prefer event approach among those. |
|
OK. Got it. |
ulzha
approved these changes
Aug 24, 2018
dlstadther
added a commit
to dlstadther/luigi
that referenced
this pull request
Sep 1, 2018
* upstream-master: Fix S3Client.copy return value consistency (spotify#2488) s3client check for deprecated host keyword and raise error with the details (spotify#2493) Fix exception when toml lib is not installed (spotify#2506) Add Okko to companies that use luigi (spotify#2512) Added optional choice for hdfs clients (spotify#2487) Version 2.7.8 revert tornado upgrade Version 2.7.7 added a new event 'progress' (spotify#2498) Add Uppsala University / pharmb.io as user (spotify#2496)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ulzha PTAL
Description
Added a new event named
event.core.progress.Motivation and Context
This event can be fired by the task itself while running. The purpose is
for the task to report progress, metadata or any generic info so that
event handler listening for this can keep track of the progress of
running task.
Have you tested this? If so, how?
I have included unit tests.