MockTarget mode fixed to accept read and write like r* or w* #2519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlstadther
reviewed
Sep 12, 2018
* MockTarget mode fixed to accept read and write like r* or w* * Update mock_test.py * mock_test write bytes test fixed for python 3 * default mode added on MockTarget and default mode and none error tests added on MockFileTest
dlstadther
reviewed
Sep 13, 2018
test/mock_test.py
Outdated
| b.write("bar") | ||
| except TypeError as error: | ||
| self.assertIsNotNone(error) | ||
| self.assertIn("'NoneType' object", str(error)) |
There was a problem hiding this comment.
can this test use assertRaises?
dlstadther
reviewed
Sep 13, 2018
test/mock_test.py
Outdated
| with t.open(None) as b: | ||
| b.write("bar") | ||
| except TypeError: | ||
| self.assertRaises(TypeError) |
There was a problem hiding this comment.
with this being in an except, we can't guarantee that the assertion is risen
i was expecting
t = MockTarget("foo")
with self.assertRaises(TypeError):
with t.open(None) as b:
b.write("bar")There was a problem hiding this comment.
Ok, going to refactor it then
dlstadther
approved these changes
Sep 13, 2018
|
No problem, it was my first time doing a PR to an open source project and I was able to learn more of python :) |
dlstadther
added a commit
to dlstadther/luigi
that referenced
this pull request
Sep 28, 2018
* upstream-master: Add Python 3.7 compatibility (spotify#2466) Refactor s3 copy into sub-methods (spotify#2508) Remove s3 bucket validation prior to file upload (spotify#2528) Version 2.7.9 set upper bound of python-daemon Update MockTarget mode to accept r* or w* (spotify#2519)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the mock target class to accept open modes such as rb, rt, wb and others
Motivation and Context
I did it because I am testing some luigi tasks using pickle and the wb wasn't working because of the mode == 'w' instead of mode[0] == 'w' comparation
Have you tested this? If so, how?
I have included a test for bytearray at mock_test.py