8000 fixes #2223 HdfsTarget is not workging with snakebite by zwotzie · Pull Request #2572 · spotify/luigi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fixes #2223 HdfsTarget is not workging with snakebite #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 21, 2019
Merged

fixes #2223 HdfsTarget is not workging with snakebite #2572

merged 8 commits into from
Jan 21, 2019

Conversation

zwotzie
Copy link
Contributor
@zwotzie zwotzie commented Nov 6, 2018 •
edited
Loading

Description

Full History you can find here: #2223

I only added the FileNotFoundException if you are using snakebite. The "old" code doesn't expect this, but in only one class behind in the same file it does.

Motivation and Context

to update > 2.6.1 :)

Have you tested this? If so, how?

yes of cause see Issue...

This change does not break anything, so i don't have added additional tests.

@dlstadther
Copy link
Collaborator

Is this not the same as #2549 ?

@zwotzie
Copy link
Contributor Author
zwotzie commented Nov 6, 2018 •
edited
Loading

first i thought it would be the same and tested 2.8.0, but it is different. #2549 do only fix the problem in HdfsAtomicWriteDirPipe but not in the class HdfsAtomicWritePipe a view lines above.

dlstadther
dlstadther approved these changes Nov 6, 2018
View reviewed changes
Copy link
Collaborator
@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, i see. It's the same changes to the same method name. But in a different class. I see. Apologies

LGTM

@zwotzie
Copy link
Contributor Author
zwotzie commented Nov 6, 2018

:)

@zwotzie
Copy link
Contributor Author
zwotzie commented Dec 17, 2018

Hi, is there a reason why this merge is not already integrated?

@dlstadther
Copy link
Collaborator

Could you merge in master to verify that tests pass? Sorry for not finishing this sooner

@zwotzie
Copy link
Contributor Author
zwotzie commented Jan 21, 2019

Hmmmm, nothing happen here for this easy change... It is a bit frustrating

@dlstadther
Copy link
Collaborator

@zwotzie Currently the tests against this branch are failing. I believe this is due to branching off a bad master. We prefer not to merge branching which have tests failing, even if the changes reflected in this PR aren't the cause of the test failures.

The master branch is currently passing. So could you please merge master into this branch so that we can evaluate Travis' test results? If all passes, i'll merge.

@zwotzie zwotzie requested a review from honnix as a code owner January 21, 2019 14:27
@zwotzie
Copy link
Contributor Author
zwotzie commented Jan 21, 2019

thanks for you advice. done :)

@dlstadther
Copy link
Collaborator

All tests pass! Appreciate it!

@dlstadther dlstadther merged commit c165ead into spotify:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlstadther dlstadther dlstadther approved these changes

@Tarrasch Tarrasch Awaiting requested review from Tarrasch

@ulzha ulzha Awaiting requested review from ulzha

@honnix honnix Awaiting requested review from honnix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwotzie @dlstadther
0