8000 contrib: Add ExternalDailySnapshot by brianmartin · Pull Request #2591 · spotify/luigi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

contrib: Add ExternalDailySnapshot #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2018
Merged

contrib: Add ExternalDailySnapshot #2591

merged 1 commit into from
Dec 6, 2018

Conversation

brianmartin
Copy link
Contributor

It is common to depend on the latest version of an ExternalTask, but not be concerned with
when that external task was generated.

I think this concern is generic enough to warrant having it upstream.

In addition to unit tests, this has been in wide use at Spotify for several years.

@brianmartin brianmartin force-pushed the add-external-daily-snapshot branch from dae3562 to 14afbae Compare November 28, 2018 16:38
@brianmartin brianmartin changed the title contrib: Add ExternalDailyTask contrib: Add ExternalDailySnapshot Nov 28, 2018
@brianmartin brianmartin mentioned this pull request Nov 28, 2018
Closed
@brianmartin brianmartin force-pushed the add-external-daily-snapshot branch from 14afbae to fdbf5ba Compare November 28, 2018 18:17
dlstadther
dlstadther approved these changes Nov 29, 2018
View reviewed changes
Copy link
Collaborator
@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any problem with this. Thanks for the tests and confirmation that this has been used in production for quite awhile!

@brianmartin
Copy link
Contributor Author

Thanks for the review @dlstadther!

Tarrasch
Tarrasch approved these changes Dec 2, 2018
View reviewed changes
Copy link
Contributor
@Tarrasch Tarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, even I remember ExternalDailySnapshot. :)

test/contrib/external_daily_snapshot_test.py Outdated
self.assertEquals(d.date, datetime.date(2012, 1, 1)) # Should still be the same


if __name__ == "__main__":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need this. See the docs for how we run the tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

@brianmartin
contrib: Add ExternalDailySnapshot
ce82962 
It is common to depend on the latest version of an ExternalTask, but not be concerned with
when that external task was generated.
@brianmartin brianmartin force-pushed the add-external-daily-snapshot branch from fdbf5ba to ce82962 Compare December 3, 2018 15:11
@brianmartin
Copy link
Contributor Author

Hey folks, thanks again for the reviews! Are we waiting on @ulzha for review, or good to go here? If everything's good, I'd like to merge to ensure I don't miss the next release.

@dlstadther
Copy link
Collaborator

We're good to go! Thanks for following up @brianmartin

@dlstadther dlstadther merged commit 4b2b3d3 into spotify:master Dec 6, 2018
@brianmartin brianmartin deleted the add-external-daily-snapshot branch December 6, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tarrasch Tarrasch Tarrasch approved these changes

@dlstadther dlstadther dlstadther approved these changes

@ulzha ulzha Awaiting requested review from ulzha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianmartin @dlstadther @Tarrasch
0