Fix durations in D3 graph (fixes #2620) #2624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarrasch
approved these changes
Jan 16, 2019
| }); | ||
| } else { | ||
| g.setEdge(task.inputQueue[i], task.taskId, { | ||
| label: "> 24h", |
There was a problem hiding this comment.
Can you remove this repetition?
There was a problem hiding this comment.
Sorry for the slow response. Fixed in the latest commit.
Fixes the duration calculation. Both date objects `startTime` and `finishTime` are in milliseconds, so the additional multiplication with 1000 was wrong. Also, the duration is now calculated with: duration = last_updated - time_running as it is done in datadog_metric.py:83 I decided to not display the time if the duration is longer than a day, because then it gets messy with the Date objects (would require a conversion to day of year, not day of month).
d81ba71 to
4b0f2d2
Compare
|
We tested this patch with a bunch of pipelines and it worked fine. In the long run, I think it makes sense to refactor the code so that the durations are displayed in the node box - but I suggest to merge this first so we don't have wrong values anymore :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the duration calculation. Both date objects
startTimeandfinishTimeare in milliseconds, so the additional multiplication with1000 was wrong.
Also, the duration is now calculated with:
as it is done also in
luigi/luigi/contrib/datadog_metric.py
Line 83 in eadf7ab
The display format was also problematic, because it only displayed the
seconds of the
Dateobject, i.e. always less than 60 seconds. Now ituses the
hh:mm:ss:fformat.I decided to not display the time if the duration is longer than a day,
because then it gets messy with the Date objects (would require a
conversion to day of year, not day of month).