add beam_dataflow_task to luigi/contrib #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarrasch
reviewed
Mar 19, 2019
daikeshi
reviewed
Mar 20, 2019
|
@Tarrasch Thanks for looking at this. We will take over and continue with the review. |
|
LGTM! 👍 |
honnix
reviewed
Mar 26, 2019
narape
reviewed
Mar 26, 2019
honnix
requested changes
Mar 26, 2019
honnix
reviewed
Apr 12, 2019
honnix
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2665
Adds a task for Beam Dataflow jobs to luigi/contrib, mostly as a wrapper for DF execution params and formatting of input/output URIs, with callbacks on successful/unsuccessful execution. Also provides an (overridable) runner to monitor job execution after submitting the job.
CC @daikeshi