8000 Require at least python-dateutil version 2.7.5 instead of only 2.7.5 … by soxofaan · Pull Request #2679 · spotify/luigi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Require at least python-dateutil version 2.7.5 instead of only 2.7.5 … #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2019
Merged

Require at least python-dateutil version 2.7.5 instead of only 2.7.5 … #2679

merged 1 commit into from
Mar 22, 2019

Conversation

soxofaan
Copy link
Contributor

Fixes #2662

Description

See setup.py diff: replaces python-dateutil==2.7.5 dependency with python-dateutil>=2.7.5.

Motivation and Context

Luigi as a library should not pin down a dependency on an exact version, but specify an "at least" constraint.

python-dateutil 2.8.0 was released on Feb 5 2019

@soxofaan soxofaan force-pushed the issue-2662-dateutil branch from e880b3a to bbe42cd Compare March 21, 2019 16:11
@soxofaan soxofaan mentioned this pull request Mar 21, 2019
Merged
@lallea
Copy link
Contributor
lallea commented Mar 22, 2019

I wrote the original line of code, and agree that this PR is a beneficial change. :-)

@honnix
Copy link
Member
honnix commented Mar 22, 2019

Reasonable change. Thank you for contribution. Could you please put upper boundary limiting to major version? We used to have issues with some dependency, e.g tornado.

@soxofaan soxofaan force-pushed the issue-2662-dateutil branch from bbe42cd to a0717ec Compare March 22, 2019 09:17
@soxofaan
Copy link
Contributor Author

@honnix done

@honnix honnix merged commit 44f89a2 into spotify:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honnix honnix honnix approved these changes

@dlstadther dlstadther dlstadther approved these changes

@Tarrasch Tarrasch Awaiting requested review from Tarrasch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soxofaan @lallea @honnix @dlstadther
0