8000 aws batch : job queue as parameter by dav009 · Pull Request #2689 · spotify/luigi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

aws batch : job queue as parameter #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2019
Merged

aws batch : job queue as parameter #2689

merged 3 commits into from
May 7, 2019

Conversation

dav009
Copy link
Contributor
@dav009 dav009 commented Apr 7, 2019

Description

allowing batch tasks to pass job_queue as a parameter when scheduling a task.
default behaviour is left untouched.

Motivation and Context

  • in environments with multiple compute engines and job queues this is a useful parameter.

Have you tested this? If so, how?

  • locally scheduled a task in a particular queue

@dlstadther
Copy link
Collaborator

@jfeala Given you added aws batch support, could you confirm this looks good to you? Thanks

@jfeala
Copy link
Contributor
jfeala commented Apr 15, 2019

Looks good to me

Copy link
Collaborator
@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given aws batch contributor approval, i'll approve and merge

@dlstadther dlstadther merged commit 994500f into spotify:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0