8000 fix calling method on wrong object by honnix · Pull Request #2709 · spotify/luigi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix calling method on wrong object #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2019
Merged

fix calling method on wrong object #2709

merged 1 commit into from
May 16, 2019

Conversation

honnix
Copy link
Member
@honnix honnix commented May 15, 2019

Description

This fixes bug introduce by #2704. Address #2708.

Motivation and Context

Have you tested this? If so, how?

Unit test

< 8000 div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> @honnix
Copy link
Member Author
honnix commented May 15, 2019

PTAL @Globegitter @dbolshak

Copy link
@dbolshak dbolshak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@honnix, thank you,
LGTM

@honnix honnix merged commit 9572d16 into master May 16, 2019
@honnix honnix deleted the fix-prometheus branch May 16, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0