8000 Expandable Namespace Folders for the Visualiser Sidebar by stuson · Pull Request #2716 · spotify/luigi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Expandable Namespace Folders for the Visualiser Sidebar #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 15, 2019

Conversation

stuson
Copy link
Contributor
@stuson stuson commented May 28, 2019

Description

Added expandable folders based off namespace to the sidebar on the task visualiser. Additionally added a clear selection button to avoid having to re-expand a folder to deselect a task family.

Updated sidebar screenshot

Motivation and Context

We have a very long list of tasks on our machine and would end up scrolling through that list trying to find the task we wanted. I originally wrote this as a JS bookmarklet for our team, but I've adapted it for the source code.

Have you tested this? If so, how?

I have ran the visualiser locally and it works.

@dlstadther
Copy link
Collaborator

What does this look like if you do not explicitly specify namespaces for your tasks? Are they all grouped into one namespace - the default?

@stuson
Copy link
Contributor Author
stuson commented May 28, 2019

Tasks with no namespace are grouped into "Others"

@stuson
Copy link
Contributor Author
stuson commented May 28, 2019

Updated: The "Others" section is now expanded by default, avoiding extra clicks when no namespaces are specified.

@stuson
Copy link
Contributor Author
stuson commented May 28, 2019

Another update: The folder containing the currently selected family should be expanded on page load too I think. If there's no selected family expand the "Others" folder.

@dlstadther
Copy link
Collaborator

@stuson Can you confirm that this code is working as expected? And that you've been using it in production for awhile?

@dlstadther
Copy link
Collaborator

Would you also be able to replace the README image for central scheduler image with this version?

@Tarrasch
Copy link
Contributor

Would you also be able to replace the README image for central scheduler image with this version?

That would be great - but I wouldn't block this PR on this. I recall we even had a screenshot the old UI for over a year. :)

@Tarrasch
Copy link
Contributor

This feature looks great by the way. I'm totally supporting an effort on evangelizing usage of namespaces.

@stuson
Copy link
Contributor Author
stuson commented Jun 11, 2019

@stuson Can you confirm that this code is working as expected? And that you've been using it in production for awhile?

We've been using this for about a month with no issues so far for us.

@Tarrasch Tarrasch merged commit 1ed319b into spotify:master Jun 15, 2019
9553
@Tarrasch
Copy link
Contributor

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0