8000 All configuration parameters in docs now use underscore in their names for consistency by svetlyak40wt · Pull Request #2890 · spotify/luigi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

All configuration parameters in docs now use underscore in their names for consistency #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

svetlyak40wt
Copy link
Contributor

Previously it was hard to search some parameters on the page because in some places a minus sign
was used and in others is underscore.

This commit fixes this issue.

Also, it fixes a few places where one backquote was used to denote a parameter name or value.
RestructuredText format uses two backquotes to denote an inline code block:

https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#inline-markup

…s for consistency.

Previosly it was hard to search some parameters on page because in some places a minus sign
was used and in others is underscore.

This commit fixes this issue.

Also, it fixes few places where one backquote was used to denote a parameter name or value.
RestructuredText format uses two backquotes to denote an inline code block:

https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#inline-markup
@svetlyak40wt svetlyak40wt force-pushed the consistent-parameters-in-docs branch from 21edbd7 to 34167a2 Compare February 5, 2020 12:49
@svetlyak40wt
Copy link
Contributor Author

Don't know, show to fix codecov/changes.

Are there any suggestions?

@Tarrasch Tarrasch merged commit fbb7e4a into spotify:master Mar 4, 2020
@Tarrasch
Copy link
Contributor
Tarrasch commented Mar 4, 2020

Thanks for the change @svetlyak40wt !!!! I'm sorry for the very slow merge, I try to check Luigi at least monthly, but I'm not maintaining it so actively now.

@svetlyak40wt
Copy link
Contributor Author

Isn't Spotify interested in Luigi anymore?

@svetlyak40wt svetlyak40wt deleted the consistent-parameters-in-docs branch March 4, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0