Fix docs explaining write modes for Luigi Targets. Closes #2783 #2931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlstadther
approved these changes
Apr 14, 2020
|
Late to the party, but I came here from #2905. What is |
from luigi.format import NopIt's just a no-op. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added some documentation under
Task.run()and under the API docs fortarget.FileSystemTargetexplaining not to use the binarybflag, but instead useformat=Nop. This closes #2783 , at least for now. In the future, we might want to instead throw a warning explaining not to useb.Motivation and Context
Closes #2783 .
Have you tested this? If so, how?
Built + opened documentation locally and it seems to have worked.