Show task progress in visualizer workers tab. #2932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've never dealt with the UI portion of Luigi. Do you have a colleague you can tag for review? Or perhaps a previous Luigi UI contributor? I like the idea here. |
|
Sorry for the late reply. I've checked out the PR based on the gist, everything worked as expected and looks good to me. |
|
@yrath Thanks for testing! |
|
@dlstadther Is this ok for you or should I provide additional tests? |
|
Fellow review and testing works for me here. I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the task progress percentage as a bootstrap progress bar in a new column to the table of running tasks in the "Workers" tab:
The value is even updated when the message modal of the specific task is open (which already had the ability to update task messages and progress via polling).
I didn't include the new column in the actual "Task List" tab, because it is probably only important for currently running tasks.
Motivation and Context
When dealing with a couple long-running tasks, it is a nice feature to see the progress per task already in the worker tab.
Have you tested this? If so, how?
The behavior is rather static, and I couldn't find existing tests that check similar features. However, I verified that the automatic updating via the
refreshIntervalof the opened modal is working properly and handles alsonullvalues.