Add documentation for the check_complete_on_run config setting #2961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePletch
commented
Jun 15, 2020
| @@ -364,7 +364,14 @@ check_unfulfilled_deps | |||
| force_multiprocessing | |||
| By default, luigi uses multiprocessing when *more than one* worker process is | |||
| requested. When set to true, multiprocessing is used independent of the | |||
| the number of workers. | |||
| number of workers. | |||
There was a problem hiding this comment.
this has bothered me for ages
dlstadther
approved these changes
Jun 15, 2020
|
Thanks for updating documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds documentation for the check_complete_on_run configuration setting that I introduced several months ago.
Motivation and Context
There have been a handful of issues opened that were solved by using this setting, which is difficult to discover. I've been meaning to do this for months.
Have you tested this? If so, how?
I have re-read the documentation in this pull request and, as a native English speaker, confirmed it is grammatically and semantically sound.