Fixing problem with ListParameter and Dynamic Dependencies #2970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlstadther
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
@jamescooke makes a good point on your linked issue, but this patch also makes sense to me. So i approve.
dlstadther
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix is to allow ListParameter parsing to return None or a list.
Motivation and Context
Here we are addressing issue #2969
It is necessary to allow the same behavior as a regular task's parameter handling on a task with dynamic requirements.
Have you tested this? If so, how?
Yes, I executed the same example reported in the issue and it fixes the problem.
Edit: also added tests on test/parameter_test.py