Use updated uri for gcs batch reqs #2998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honnix
reviewed
Sep 18, 2020
| @@ -231,7 +234,7 @@ def remove(self, path, recursive=True): | |||
| raise InvalidDeleteException( | |||
| 'Path {} is a directory. Must use recursive delete'.format(path)) | |||
|
|
|||
| req = http.BatchHttpRequest() | |||
| req = http.BatchHttpRequest(batch_uri=GCS_BATCH_URI) | |||
There was a problem hiding this comment.
So google api client doesn't set this as default? It's a bit surprising.
There was a problem hiding this comment.
The default still goes to the global batch uri (https://www.googleapis.com/batch) - now there's a different batch endpoint for each api (but BatchHttpRequest is still generic to request type) so you need to set it to the uri for whatever api you are using
honnix
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default batch_uri used by BatchHttpRequest is deprecated: https://developers.googleblog.com/2018/03/discontinuing-support-for-json-rpc-and.html
This update uses the gcs specific batch uri in gcs_client and bumps google-api-python-client's lower bound to make sure we use a compatible version. Currently batch removals using the client are calling the deprecated uri (https://github.com/googleapis/google-api-python-client/blob/master/googleapiclient/http.py#L1175).
Have you tested this? If so, how?
I have run the gcs_client test which covers batch removal and I also tested end-to-end with an actual luigi job we use this in.