8000 Flush stream_for_searching_tracking_url by jarno-r · Pull Request #3000 · spotify/luigi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Flush stream_for_searching_tracking_url #3000

New issue
Merged
merged 1 commit into from
Jan 13, 2021
Merged

Flush stream_for_searching_tracking_url #3000

merged 1 commit into from
Jan 13, 2021

Conversation

jarno-r
Copy link
Contributor
@jarno-r jarno-r commented Sep 18, 2020

A fix for issue 2999

Description

Flush the stream

Motivation and Context

Issue 2999 - ExternalProgramTask: stream_for_searching_tracking_url is not flushed, causing program output to be lost.

Have you tested this? If so, how?

"I ran my jobs with this code and it works for me."

Copy link
Collaborator
@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@harpaj
Copy link
Contributor
harpaj commented Jan 13, 2021

@dlstadther, do you think this could be merged? It's really a quite annoying regression for debugging Spark tasks.
I can also confirm that the change fixes the problem.

@dlstadther dlstadther merged commit 3d9fa41 into spotify:master Jan 13, 2021
hirosassa pushed a commit to hirosassa/luigi that referenced this pull request Jan 15, 2021
Co-authored-by: Jarno Rajala <jarno.rajala@schibsted.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0