8000 Add support for __init_subclass in Task metaclass. by umartin · Pull Request #3154 · spotify/luigi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for __init_subclass in Task metaclass. #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Add support for __init_subclass in Task metaclass. #3154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71542b7
Add support for __init_subclass in Task metaclass.
umartin Apr 12, 2022
c372d75
Merge branch 'master' into master
umartin Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions luigi/task_register.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class Register(abc.ABCMeta):
ambiguous task name (two :py:class:`Task` have the same name). This denotes
an error."""

def __new__(metacls, classname, bases, classdict):
def __new__(metacls, classname, bases, classdict, **kwargs):
"""
Custom class creation for namespacing.

Expand All @@ -63,7 +63,7 @@ def __new__(metacls, classname, bases, classdict):
When the set or inherited namespace evaluates to ``None``, set the task namespace to
whatever the currently declared namespace is.
"""
cls = super(Register, metacls).__new__(metacls, classname, bases, classdict)
cls = super(Register, metacls).__new__(metacls, classname, bases, classdict, **kwargs)
cls._namespace_at_class_time = metacls._get_namespace(cls.__module__)
metacls._reg.append(cls)
return cls
Expand Down
12 changes: 12 additions & 0 deletions test/task_test.py
792D
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,3 +409,15 @@ class MyTask(luigi.Task):
pass
luigi.namespace(scope='incorrect_namespace')
self.assertEqual(MyTask.get_task_namespace(), '')


class InitSubclassTest(LuigiTestCase):
def test_task_works_with_init_subclass(self):
class ReceivesClassKwargs(luigi.Task):
def __init_subclass__(cls, x, **kwargs):
super(ReceivesClassKwargs, cls).__init_subclass__()
cls.x = x

class Receiver(ReceivesClassKwargs, x=1):
pass
self.assertEquals(Receiver.x, 1)
0