Feat 8000 ure/add configuration metrics #23
Conversation
…er_connections config metrics
…uncer_config_max_client_conn and pgbouncer_config_max_user_connections metrics
|
Hi @esanchezm , I hope you are doing well. |
There was a problem hiding this comment.
Overall looks good, thank you @jgduarte-stratio . I just found some style issues and minor things, could you please fix them? Ping me when it's done 😄
… fixed PR comments like align issues
|
Hi @esanchezm, I added your fix request from my original branch. I released later that github already allowed me to do it from your change request. Anyway I fixed a bad type format when reading from the config table as it's reading values as strings. |
There was a problem hiding this comment.
Hi @jgduarte-stratio . Sorry for the late reply. I'm glad you found an issue with the returned data type, thanks for fixing it. It looks good to me, I just found that in some lines you added extra spaces at the end, could you removed them? I'll comment the lines I found, but since it's tricky, I suggest you to use a trailing space removal plugin in your IDE or editor 😄
Trim spaces Co-authored-by: Esteban Sanchez <esteban.sanchez@gmail.com>
Trim spaces Co-authored-by: Esteban Sanchez <esteban.sanchez@gmail.com>
Trim spaces Co-authored-by: Esteban Sanchez <esteban.sanchez@gmail.com>
Trim spaces Co-authored-by: Esteban Sanchez <esteban.sanchez@gmail.com>
Trim spaces Co-authored-by: Esteban Sanchez <esteban.sanchez@gmail.com>
Trim spaces Co-authored-by: Esteban Sanchez <esteban.sanchez@gmail.com>
|
No worries, and thank you for your feedback |
|
Hi @esanchezm , I hope you're doing well. Would you have time to check everything is right now? |
There was a problem hiding this comment.
Hi @jgduarte-stratio ! Thanks for addressing my feedback. I added @RichardFord-VN as a reviewer but it LGTM so I'm approving it
|
@jgduarte-stratio we just released a new version 2.1.0. Please check the release notes in https://github.com/spreaker/prometheus-pgbouncer-exporter/releases |
|
Great news! thank you very much.
I hope we can start using it next week.
El El vie, 10 jul 2020 a las 16:11, Esteban Sanchez <
notifications@github.com> escribió:
@jgduarte-stratio <https://github.com/jgduarte-stratio> we just released
a new version 2.1.0. Please check the release notes in
https://github.com/spreaker/prometheus-pgbouncer-exporter/releases
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE6UWE4KHWISLC5YUHO6MTLR24OSPANCNFSM4NEEU5UA>
.
--
| José Gabriel Duarte
+34 663 817 893 / Ext: 2104
Vía de las dos Castillas, 33, Ática 4, 2ª Planta
28224 Pozuelo de Alarcón, Madrid, Spain
+34 918 286 473 | www.stratio.com
<https://twitter.com/stratiobd> <https://www.linkedin.com/company/stratiobd>
<https://www.youtube.com/channel/UCoI1xy_cEsULLD8ZMiOCP1A>
…------------------------------
This e-mail and the information contained in it is confidential and it is
addressed exclusively to the recipient named in the heading. If you have
received or accessed this message by error, please notify us and proceed to
erase it immediately. Any unauthorized disclosure, copying, distribution or
use of the information contained therein is prohibited by law. The personal
data provided by you or by third parties are the responsibility of STRATIO
in order to manage and maintain contacts and relationships that occur as a
result of the relationship with STRATIO. Normally, the legal basis that
legitimates this processing, will be your consent, our legitimate interest
or the need to manage a contractual relationship with you. The storage
period of your data will be determined by your relationship with us.
STRATIO's email service is outsourced with Google, which implies an
international transfer of your contact data to the United States; however,
Google provides adequate data protection guarantees, by adhering to the
Privacy Shield framework, and because of the authorization TI/00153/2017 of
the Spanish Data Protection Agency (AEPD) to transfer personal data to the
United States. For further information, or to exercise your rights of
access, rectification, erasure, objection, limitation or portability,
please write to privacy@stratio.com. Likewise, in the event that you
consider your data protection rights violated in any manner, you may file a
claim with the AEPD (www.aepd.es).
|
It is really useful to be able to compare existing metrics with allowed maximums.
A new database metric with max_connections column has been added.
A new set of metrics with configuration values is now available. Current available values are max_client_conn and max_user_connections