8000 Fix template path · Issue #25 · sprity/sprity · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix template path #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rwu823 opened this issue Jul 20, 2015 · 1 comment
Open

Fix template path #25

rwu823 opened this issue Jul 20, 2015 · 1 comment
Labels
enhancement

Comments

@rwu823
Copy link
rwu823 commented Jul 20, 2015

sprity/lib/style.js

Line 34 in 6b91822

var templatePath = path.join(process.cwd(), opt.template);

I think here should check is it absolute path or not?

sometime we write:

{
  template: __dirname  + '/template/xxx.hbs'
}
@rwu823 rwu823 mentioned this issue Aug 30, 2015
Open
@Congelli501
Copy link

This is a bug, not an enhancement, and this is a regression compared to css-sprite 0.9.8 which didn't have this issue.

You can't provide an absolute path to the "template" option, as sprity will concat the cwd with the provided path, leading to an invalid path.

Congelli501 added a commit to Congelli501/sprity that referenced this issue May 1, 2016
< 572C div class="AvatarStack-body" > @Congelli501
Fix sprity#25: allow absolute or relative template path
96e3255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aslansky @Congelli501 @rwu823
0