8000 Support node.js 6.* by blitss · Pull Request #71 · sprity/sprity · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support node.js 6.* #71

New issue
Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support node.js 6.* #71

wants to merge 1 commit into from

Conversation

blitss
Copy link
@blitss blitss commented Sep 17, 2016 •
edited
Loading

When I compile with node 6.3.0 I get c 8000 ompilation error:

/var/project
> └─┬ lwip@0.0.9 
>   ├── async@2.0.1 
>   ├── bindings@1.2.1 
>   └─┬ decree@0.0.6 
>     └── lodash-node@2.4.1 
> 
> npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
> npm WARN notsup Not compatible with your operat
> 
> exit
> ^C
root@instance-3:/var/task-money/gpt_frontend# 
root@instance-3:/var/task-money/gpt_frontend# npm i sprity
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

> lwip@0.0.8 install /var/task-money/gpt_frontend/node_modules/sprity-lwip/node_modules/lwip
> node-gyp rebuild

make: Entering directory `/var/task-money/gpt_frontend/node_modules/sprity-lwip/node_modules/lwip/build'
  CXX(target) Release/obj.target/lwip_decoder/src/decoder/init.o
In file included from ../src/decoder/decoder.h:13:0,
                 from ../src/decoder/init.cpp:1:
../../nan/nan.h:590:20: error: variable or field ‘AddGCEpilogueCallback’ declared void
       v8::Isolate::GCEpilogueCallback callback
                    ^
../../nan/nan.h:590:7: error: ‘GCEpilogueCallback’ is not a member of ‘v8::Isolate’
       v8::Isolate::GCEpilogueCallback callback
       ^
../../nan/nan.h:591:18: error: expected primary-expression before ‘gc_type_filter’
     , v8::GCType gc_type_filter = v8::kGCTypeAll) {
                  ^
../../nan/nan.h:596:20: error: variable or field ‘RemoveGCEpilogueCallback’ declared void
       v8::Isolate::GCEpilogueCallback callback) {
                    ^
../../nan/nan.h:596:7: error: ‘GCEpilogueCallback’ is not a member of ‘v8::Isolate’
       v8::Isolate::GCEpilogueCallback callback) {
       ^
../../nan/nan.h:601:20: error: variable or field ‘AddGCPrologueCallback’ declared void
       v8::Isolate::GCPrologueCallback callback
                    ^
../../nan/nan.h:601:7: error: ‘GCPrologueCallback’ is not a member of ‘v8::Isolate’
       v8::Isolate::GCPrologueCallback callback
       ^
../../nan/nan.h:602:18: error: expected primary-expression before ‘gc_type_filter’
     , v8::GCType gc_type_filter = v8::kGCTypeAll) {
                  ^
../../nan/nan.h:607:20: error: variable or field ‘RemoveGCPrologueCallback’ declared void
       v8::Isolate::GCPrologueCallback callback) {
                    ^
../../nan/nan.h:607:7: error: ‘GCPrologueCallback’ is not a member of ‘v8::Isolate’
       v8::Isolate::GCPrologueCallback callback) {
       ^
make: *** [Release/obj.target/lwip_decoder/src/decoder/init.o] Error 1
make: Leaving directory `/var/task-money/gpt_frontend/node_modules/sprity-lwip/node_modules/lwip/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)
gyp ERR! System Linux 3.19.0-66-generic
gyp ERR! command "/usr/bin/nodejs" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /var/project/node_modules/sprity-lwip/node_modules/lwip
gyp ERR! node -v v6.3.0
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok 
npm WARN install:lwip@0.0.8 lwip@0.0.8 install: `node-gyp rebuild`
npm WARN install:lwip@0.0.8 Exit status 1

We need to update sprity-lwip up to 1.0.6

@coveralls
Copy link
coveralls commented Sep 17, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 95.62% when pulling f49d717 on Blitss:patch-1 into 0a39d86 on sprity:master.

@TylerBre
Copy link

for the love of all that is holy, please merge and release this 👍
< 8000 !-- -->
@nealfennimore
Copy link

Until this is merged, I have this working with 6.3.1 on this fork: https://github.com/nealfennimore/sprity

npm uninstall sprity --save and then in package.json add:
"sprity": "git://github.com/nealfennimore/sprity",

And then npm install.

@allenz-crypto allenz-crypto mentioned this pull request Nov 10, 2016
Open
wmfgerrit pushed a commit to wikimedia/wikimedia-portals that referenced this pull request Dec 5, 2016
@jandre3000 @MarcoAurelioWM
Adding Node 6 compatibility to dependancies
444898d 
Making the gulp tasks work with Node 6.
- fixing `gulp sprite` by swapping out the official
  version of sprity for a forked one that works with
  node 6. See sprity/sprity#71
- fixing `gulp fetch-meta` by replace `gulp-download`
  with a curl command.
- upgrading all npm packages.

This patch requires deleting your node_modules dir
and doing a fresh npm install.

Bug: T150190
Change-Id: Ia031b43aed5a293c0fa313149503e3ac60122cd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blitss @coveralls @TylerBre @nealfennimore
0