#1296: Adding Pattern annotation support #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @author : ashutosh | ||
| * 29/04/2016 | ||
| */ | ||
| public class PatternTestModel { |
There was a problem hiding this comment.
Probably it would be good to add here an example when we have both annotations @Size and @Pattern assigned to one field and check that both information is kept in the context? This might help to understand to somebody who will be interesting how it should work in this specific case. How do you think?
|
Thanks for the pr! More importantly thanks for working together to get this working @ashutosh-shirole and @igor-sokolov! Sorry it took so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do/fix?
Provide support for @pattern annotation of JSR-303. #1296
Are there unit tests? If not how should this be manually tested?
There are new Unit tests added for Pattern tests, Similar to SizeAnnotation plugin.
Any background context you want to provide?
Some changes had to be made in core module. ModelPropertyBuilder, ModelProperty from springfox-core and ModelMapper from springfox-swagger2 and their tests had to be changed.
What are the relevant issues?
#1296 and #1314