8000 #1373 - Modified how to set jsonEditor parameter by miborra · Pull Request #1386 · springfox/springfox · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#1373 - Modified how to set jsonEditor parameter #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

miborra
Copy link
Contributor
@miborra miborra commented Jul 13, 2016

What's this PR do/fix?

This PR modifies how to set jsonEditor parameter to solve problem related on #1373 task

Are there unit tests? If not how should this be manually tested?

No there aren't. To test it you should configure UiConfiguration with enableJsonEditor parameter to false. In swagger page, the button Try it! shouldn't be accesible.

Any background context you want to provide?

No

What are the relevant issues?

#1373

@dilipkrish dilipkrish merged commit fb305ad into springfox:master Jul 13, 2016
@dilipkrish dilipkrish added the PR label Jul 13, 2016
@dilipkrish dilipkrish added this to the 2.6.0 milestone Jul 13, 2016
@dilipkrish
Copy link
Member

👍 thanks for catching that! Do you know if this is a problem in all browsers or just a particular browser?

@miborra
Copy link
Contributor Author
miborra commented Jul 14, 2016

In all browsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0