Support explicit ordering for Tags #2048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
============================================
+ Coverage 95.77% 95.77% +<.01%
- Complexity 2730 2732 +2
============================================
Files 317 317
Lines 5988 5993 +5
Branches 494 495 +1
============================================
+ Hits 5735 5740 +5
Misses 146 146
Partials 107 107 |
|
@jroweboy Thanks this is awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for explicitly ordering
Tags when manually adding tags to aDocketThis code addresses issue #1900 and is based heavily off rainoko's code that was linked in the issue. A unit test was added to show that ordering tags should be ordered first based on priority and second by name. In order to support a second sorting order, the comparator is kept around, even though tags implement
Orderednow.(In other news, I don't know if this has been reported, but running the gradle tests on windows doesn't work if you have configured git to pull with windows line endings and push with unix line endings. This is because the test cases often compare multiline strings and they will fail because of the added
\rthanks to windows line endings.)