change BaseClass test class to run as a MockitoJunitRunner, instead … #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I'm not sure I would want to do this without explaining it in the README (guide text). |
|
Agree with @dsyer. Looks like your picking Mockito DI over Spring DI. Illustrating the tradeoff in the text is a must or it could trigger an argument. |
…of starting the whole spring context
|
Hey @gunayus any chance for an update of the readme? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseClass.java is modified to run it as a Mockito Junit Runner instead of starting the whole Spring application context. This will improve the performance by eliminating the spring application context bootstrap time.