upgraded to thrift 0.6, also removed round trip from scanner adapter #1
Conversation
|
Hey, I am no longer working on this, so you are welcome to take it over and do whatever you'd like with it. Tell me if you want me to add a link to your repository in the description of this one. |
|
ok cool. I'm gonna keep hacking on it, but I won't bother you with any more also, your code was a good starting point for me, so thanks for that. On Thu, Jun 23, 2011 at 12:41 PM, sqs <
|
Not sure if you are still working on this, but if so, I updated the generated code to thrift 0.6 so it works with the thrift-0.6 gem.
Also, the scanner spec showed that when you don't pass columns explicitly to the scanner, the scanner adapter was calling:
in order to fill in the columns Array if it was missing in the given options. that was incurring a round trip (and also didn't seem to work on HBase 0.90.3, r1100350), so instead I changed
Rhino::Scanner to fill in the columns if they were missing and pass the columns Array explicitly to the scanner adapter.
Let me know if you're still working on this and want pull requests. Otherwise, I'm gonna make some other changes also. If you are, let me know what you're thinking and maybe I can help.