Clean duplicated code and some typos #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some typos in README.md Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
hyongtao-db
commented
Dec 24, 2024
| @@ -257,7 +257,7 @@ When a base table is truncated, the IMMV is also truncated and the contents beco | |||
|
|
|||
| ### Concurrent Transactions | |||
|
|
|||
| Suppose an IMMV is defined on two base tables and each table was modified in different a concurrent transaction simultaneously. In the transaction which was committed first, the IMMV can be updated considering only the change which happened in this transaction. On the other hand, in order to update the IMMV correctly in the transaction which was committed later, we need to know the changes occurred in both transactions. For this reason, `ExclusiveLock` is held on an IMMV immediately after a base table is modified in `READ COMMITTED` mode to make sure that the IMMV is updated in the latter transaction after the former transaction is committed. In `REPEATABLE READ` or `SERIALIZABLE` mode, an error is raised immediately if lock acquisition fails because any changes which occurred in other transactions are not be visible in these modes and IMMV cannot be updated correctly in such situations. However, as an exception if the IMMV has only one base table and doesn't use DISTINCT or GROUP BY, and the table is modified by `INSERT`, then the lock held on the IMMV is `RowExclusiveLock`. | |||
There was a problem hiding this comment.
This sentence is too long, I'm afraid you may find it difficult to notice where I changed it.
are not be visible
Remove be.
`refesh_immv` should be `refresh_immv`
…ation and definition - declaration: apply_new_delta_with_count(... StringInfo target_list, StringInfo aggs_set, ...) - definition: apply_new_delta_with_count(... StringInfo aggs_set, StringInfo target_list, ...) the input order is different.
yugo-n
approved these changes
Feb 12, 2025
|
I am sorry for my late response and thank you so much for your checks and fixes of types in details! |
Thanks for your work. It is my pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long log:
pg_imv.hare duplicated, and one of them can be removed.Signed-off-by: Yongtao Huang yongtaoh2022@gmail.com