README - detail on renaming IMMV + fix typo in drop IMMV #123
Conversation
| @@ -300,7 +300,7 @@ test=# SELECT immvrelid AS immv, pgivm.get_immv_def(immvrelid) AS immv_def FROM | |||
| An IMMV can be dropped using the `DROP TABLE` command. Once an IMMV is dropped, its entry is automatically removed from the `pg_ivm_immv` catalog. | |||
|
|
|||
| ```sql | |||
| test=# DROP TABLE immv; | |||
| test=# DROP TABLE immv_agg; | |||
There was a problem hiding this comment.
Made this change b/c the below query result shows the immv name to be "immv_agg". Typically the table name and immv name are the same. Trying to reduce confusion. see: https://github.com/sraoss/pg_ivm/pull/123/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L309
There was a problem hiding this comment.
I think this change is unnecessary. It makes sense that we created "immv" and "immv_agg", and dropped "immv", so only "immv_agg" appear in pg_ivm_immv.
| @@ -300,7 +300,7 @@ test=# SELECT immvrelid AS immv, pgivm.get_immv_def(immvrelid) AS immv_def FROM | |||
| An IMMV can be dropped using the `DROP TABLE` command. Once an IMMV is dropped, its entry is automatically removed from the `pg_ivm_immv` catalog. | |||
|
|
|||
| ```sql | |||
| test=# DROP TABLE immv; | |||
| test=# DROP TABLE immv_agg; | |||
There was a problem hiding this comment.
I think this change is unnecessary. It makes sense that we created "immv" and "immv_agg", and dropped "immv", so only "immv_agg" appear in pg_ivm_immv.
Thank you for your proposal! It seems nice because pg_ivm support renaming using ALTER TABLE. |
In my testing, renaming the table seems to not break the IMMV. So I thought the readme should reflect that. If renaming isn't supported, then I'd recommend the readme reflecting that instead.
Thanks for an awesome extension!