Fix Windows linkage errors by adding PGDLLEXPORT to function declarations #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions The following functions in pg_ivm.h are now explicitly marked with PGDLLEXPORT: - IVM_immediate_before - IVM_immediate_maintenance - ivm_visible_in_prestate This change resolves linkage mismatches between function declarations in the header and their definitions using PG_FUNCTION_INFO_V1 in the implementation file, which caused build failures on Windows environments.
yugo-n
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix build errors on Windows by adding PGDLLEXPORT to some function declarations in pg_ivm.h.
Details
This PR adds the PGDLLEXPORT macro to the declarations of several functions (IVM_immediate_before, IVM_immediate_maintenance, ivm_visible_in_prestate) in pg_ivm.h.
This resolves linkage errors that occurred when building pg_ivm on Windows with PostgreSQL 17.4 and Meson, due to mismatches between the function declarations and their definitions.
References