Fix not to create IMMV icluding other IMMV(#30) #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, IMMV including IMMV in its definition was created by create_immv(), but it is not supported by IMMV. This patch now raises an error on create_immv().
yugo-n
approved these changes
Oct 18, 2022
|
Is this something that might work in the future? |
|
It might be. Enabling nesting IMMV would extremely expand the variety of supported view expressions, so I think it this should be supported in future. However, we need more research. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, IMMV including IMMV in its definition was created by create_immv(), but it is not supported by IMMV. This patch now raises an error on create_immv().