8000 Keep tabs open on error by carlosms · Pull Request #195 · src-d/gitbase-web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Keep tabs open on error #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2018
Merged

Keep tabs open on error #195

merged 2 commits into from
Jul 12, 2018

Conversation

carlosms
Copy link
Contributor

Fix #185.

There is a difference in how chrome and firefox render the gif. Chrome plays the animation only one the first time :/

Chrome:
a

Firefox:
b

Maybe we could modify the gif to be a loop, with the last frame paused for 5 minutes. What do you think @ricardobaeta, @bzz, @smacker ?

@carlosms
Keep tabs open on error
6866423 
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
@carlosms carlosms requested review from smacker and bzz July 11, 2018 17:11
@smacker
Copy link
Contributor
smacker commented Jul 11, 2018

@carlosms there is no much problem with restarting the animation. Something like this would work if you want to keep the same element: https://jsfiddle.net/ko4stxwf/4/

But with react you most probably can create new instance of img and it should work fine (most probably, I didn't test)

@ricardobaeta
Copy link
ricardobaeta commented Jul 11, 2018 •
edited
Loading

@carlosms @bzz @smacker

There's no worries creating the 5min paused loop, but i think the size of the asset will go up. Would Maxim's suggestion be better?

@carlosms
Force error img reload
418d206 
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
@carlosms
Copy link
Contributor Author

We saw 2 options, doing the img src change with a timeout, or adding ?xx to each image src.
Both are not ideal, so I went with the second one 418d206

@carlosms carlosms merged commit 86a2465 into src-d:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smacker smacker smacker approved these changes

@bzz bzz Awaiting requested review from bzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosms @smacker @ricardobaeta
0