Kill queries also after the rows start streaming #358
Conversation
server/handler/query.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| func queryContext(ctx context.Context, conn *sql.Conn, queryRequest queryRequest) (*serializer.Response, error) { |
There was a problem hiding this comment.
is it really neede to shadow queryRequest type?
There was a problem hiding this comment.
sorry, I don't follow what you mean here. Can you elaborate?
There was a problem hiding this comment.
the name of the parameter is queryRequest and the type of this parameter is queryRequest.
because of it you don't have access to the type anymore inside the function and it is a little bit confusing that queryRequest outside of this function is a type but inside an instance of this type.
There was a problem hiding this comment.
you are right, I just copied the code we had before and didn't realize that. Thanks.
I've renamed the var, and because it's a small change I already squashed it to make the branch ready to merge.
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Fix #357.
See issue for details on the bug. This PR basically makes bigger the "wrapper logic" of killing the connection on context cancellation from (
QueryContext) to (QueryContext+ rows processing).