8000 Invite pages by cryptix · Pull Request #59 · ssbc/go-ssb-room · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Invite pages #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 10, 2021
Merged

Invite pages #59

merged 12 commits into from
Mar 10, 2021

Conversation

cryptix
Copy link
Member
@cryptix cryptix commented Mar 4, 2021 •
edited
Loading

Let's merge #55 first.

  • add HTML overview page to create, list and revoke invites. (rough copy of the members overview)
  • create return page with the invite code
  • revocation pages
  • e2e HTTP tests for creation
    • stored
    • shown
  • accept
    • page
    • add to allow on accept
  • track feed of the user who created the invite
  • show tunnel address v1 room invite
  • tests for invite accept form
  • test for invite consumed page

Future TODO:

  • style the pages better (See Invites follow-up: page styling #68)
    • admin: invites overview and created
    • public: accept and consumed
  • register alias on accept
  • ssb uri
  • json/api endpoints
  • e2e tests (create, accept, test to join the room over muxrpc)

miscellaneous tweaks:

  • re-using pagination code between views (cf6c96d)
  • found a way to untangle user lookup for is_logged_in and handler functions (15501ed)
  • struct-ify database arguments (see d302423 and 78a8c3b)

cblgh
cblgh reviewed Mar 4, 2021
View reviewed changes
cblgh
cblgh reviewed Mar 4, 2021
View reviewed changes
cblgh
cblgh reviewed Mar 4, 2021
View reviewed changes
@cryptix cryptix changed the title Invite pages Admin Invite pages Mar 4, 2021
@cryptix cryptix changed the title Admin Invite pages Invite pages Mar 4, 2021
Base automatically changed from invites to master March 5, 2021 07:42
@cryptix cryptix marked this pull request as ready for review March 5, 2021 08:25
cblgh
cblgh reviewed Mar 5, 2021
View reviewed changes
cblgh
cblgh reviewed Mar 5, 2021
View reviewed changes
cblgh
cblgh reviewed Mar 5, 2021
View reviewed changes
cblgh
cblgh reviewed Mar 5, 2021
View reviewed changes
cblgh
cblgh reviewed Mar 5, 2021
View reviewed changes
cblgh
cblgh reviewed Mar 5, 2021
View reviewed changes
cblgh
cblgh reviewed Mar 5, 2021
View reviewed changes
@staltz
Copy link
Member
staltz commented Mar 9, 2021

style the pages better

I could do this, by the way

cryptix added 11 commits March 10, 2021 09:33
@cryptix
invite form testing
c7bcef4
@cryptix
re-use pagination code
9755406
@cryptix
add endpoint for create
3c58a13
@cryptix
add user.FromContext middleware
91dd601 
A helper package so that handler and render code isnt directly tied to
the authentication package.

Also reduces db lookup overhead to one request to sqlite per request for
the user lookup.
@cryptix
disambiguate redirect url 8000
fd5312b
@cryptix
more consistent type names for handlers
9f1fef1
@cryptix
Invite endpoints
98468e9 
* Add revoke and created templates
* Render invite accept with domain
* Flesh out accept page
@cryptix
Add GetByID and GetByToken to invite service
672647c
@cryptix
Various fixes
fd21dfc 
* fix accept and consumed view
* Apply suggestions from Alex' code review
* define admin.Databases options struct
* structify database parameters of web/handlers
@cryptix
check that invite.Consume adds to the allow list
6945221
@cryptix
More testing
b21e2b2 
* test for invite accept form rendering
* show placeholder if there is no suggested alias
* accept form and consume endpoint
@cryptix cryptix merged commit 04824ee into master Mar 10, 2021
@cryptix cryptix deleted the invite-pages branch March 10, 2021 08:41
This was referenced Mar 10, 2021
Closed
Open
@cblgh
Copy link
Contributor
cblgh commented Mar 10, 2021

@cryptix 👏 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staltz staltz staltz left review comments

@cblgh cblgh cblgh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cryptix @staltz @cblgh
0