8000 Add support for invite consumption via JSON by cryptix · Pull Request #105 · ssbc/go-ssb-room · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ go-ssb-room Public
< 8000 /div>

Add support for invite consumption via JSON #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2021
Merged

Add support for invite consumption via JSON #105

merged 2 commits into from
Mar 30, 2021

Conversation

cryptix
Copy link
Member
@cryptix cryptix commented Mar 26, 2021 •
edited
Loading
  • conform invites to specify invite consumption in details rooms2#35
  • change accept page to facade
  • support JSON consumption
  • support x-www-form-urlencoded
    • re-style pages (:grimacing:)
  • update consumption tests
  • re-consider CSRF bypass (It's fine, the invite code/token already is a secret)
  • remove member nickname / untangle alias suggestion

updates #13

fixes #71

cryptix
cryptix commented Mar 26, 2021
View reviewed changes
@cryptix cryptix added the Go golang related stuff label Mar 26, 2021
@cryptix cryptix marked this pull request as ready for review March 29, 2021 08:35
@cryptix cryptix changed the title convert invite consumption to JSON Add support for invite consumption via JSON Mar 29, 2021
@cryptix cryptix mentioned this pull request Mar 29, 2021
Closed
@staltz
Copy link
Member
staltz commented Mar 29, 2021

@cryptix What's the difference between invite/consumed.tmpl and invite/facade.tmpl? Both seem to display the SSB URI.

@staltz
Copy link
Member
staltz commented Mar 29, 2021

Oh, maybe I'm understanding now: is CompleteInviteConsume the submissionUrl which is POST-only? (If so, does it need an HTML page since it will only be called programmatically?)

@cryptix
Copy link
Member Author
cryptix commented Mar 29, 2021 •
edited
Loading

Oh, maybe I'm understanding now: is CompleteInviteConsume the submissionUrl which is POST-only?

yes, consumed is after they supplied their ID.

If so, does it need an HTML page since it will only be called programmatically?

I kept the HTML form in case people can't get the URIs to work with their clients and want to input the ID manually. Although I agree that it is advanced use, I'd still show the form if the handler isn't registered, together with a message that the ssb: handler isn't there.

@staltz
Copy link
Member
staltz commented Mar 29, 2021

I kept the HTML form in case people can't get the URIs to work with their clients and want to input the pub manually. Although I agree that it is advanced use, I'd still show the form if the handler isn't registered, together with a message that the ssb: handler isn't there.

Oh, right, that's decent. I think I can make a separate page (just to declutter) for the form to input the id.

@cryptix cryptix requested a review from cblgh March 30, 2021 08:38
@cryptix
Copy link
Member Author
cryptix commented Mar 30, 2021 •
edited
Loading

@staltz do you want to do the re-styling on this or a new PR? otherwise I think this is ready for review and possibly merge.

edit: possibly easier to review one patch at a time.

@staltz
Copy link
Member
staltz commented Mar 30, 2021

@cryptix Separate PR.

This one is ✔️ to merge :)

@cryptix cryptix merged commit 6409c79 into master Mar 30, 2021
@cryptix cryptix deleted the update-invites branch March 30, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arj03 arj03 arj03 left review comments

@cblgh cblgh Awaiting requested review from cblgh

Assignees
No one assigned
Labels
Go golang related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invites follow-up: JSON API endpoints
3 participants
@cryptix @staltz @arj03
0