8000 support multiserverAddress in start-http-auth URI by staltz · Pull Request #106 · ssbc/go-ssb-room · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support multiserverAddress in start-http-auth URI #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

staltz
Copy link
Member
@staltz staltz commented Mar 29, 2021

@staltz staltz marked this pull request as draft March 29, 2021 09:41
@staltz
Copy link
Member Author
staltz commented Mar 29, 2021

@cryptix I need help with the tests:

expected: "net:localhost:8008~shs:testtesttesttesttesttesttesttest"
actual  : "net:localhost:8008~shs:dGVzdHRlc3R0ZXN0dGVzdHRlc3R0ZXN0dGVzdHRlc3Q="

How do I get the testtesttesttest? I'm building the actual from ts.NetworkInfo.RoomID.PubKey().

@staltz
Copy link
Member Author
staltz commented Mar 29, 2021

Implementation of the test:

	var msaddr = fmt.Sprintf("net:%s:%d~shs:%s", ts.NetworkInfo.Domain, ts.NetworkInfo.PortMUXRPC, ts.NetworkInfo.RoomID.PubKey())
	a.Equal(msaddr, qry.Get("multiserverAddress"))

@staltz
Copy link
Member Author
staltz commented Mar 29, 2021

Oh, now I see that

dGVzdHRlc3R0ZXN0dGVzdHRlc3R0ZXN0dGVzdHRlc3Q=

is just

testtesttesttesttesttesttesttest

in base64. 🤯

@staltz staltz marked this pull request as ready for review March 29, 2021 09:59
... and implement MultiserverAddress() there.
@cryptix cryptix merged commit bd0180f into master Mar 29, 2021
@cryptix cryptix deleted the start-http-auth-msaddr branch March 29, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0