Style dashboard #107
Merged
Style dashboard #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staltz
commented
Mar 29, 2021
cryptix
reviewed
Mar 29, 2021
cryptix
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
I can live with ignoring my suggestion to get an error from Count(). We can add the error if we suspect a problem.
I pressed resolve before your suggestion was made, so I didn't ignore it. I can do the error handling and logging. |
|
And my reasoning there was that |
|
Gonna fix that merge conflict, BRB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also checked that both desktop and mobile look good.