use custom type marshalling via database/sql interface #120
Conversation
- remove cruft from sqlite package
- update sqlboiler.toml
- fix default value in migration
- add default tests
* remove cruft from sqlite package * update sqlboiler.toml * fix default value in migration * add default tests
|
|
||
| // Scan implements https://pkg.go.dev/database/sql#Scanner to read integers into a privacy mode | ||
| func (pm *PrivacyMode) Scan(src interface{}) error { | ||
| dbValue, ok := src.(int64) |
There was a problem hiding this comment.
This was src.(PrivacyMode) before, but the compiler needs to know what the database stores it as internally first.
| return err | ||
| } | ||
|
|
||
| *pm = privacyMode |
There was a problem hiding this comment.
You had pm = &privacyMode which pleases compiler semantics (left type == right type) but doesn't effect the change you want.
That way just overwrites the pointer in the scope of Scan() with a pointer to the value that was just created inside that function. As soon as the function returns, they will be gone.
The receiver *pm already points to a valid PrivacyMode, it needs to be dereferenced so that we can update the value inside, updating the number from it's zero value to the one we got from the DB.
HTH
|
thanks for finishing this up @cryptix, i think i understand a bit more what i was missing in my attempt. |